Page MenuHomePhabricator
Differential D11641

[lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData` and `UpdateFarcasterMessageData`
ClosedPublic
Actions

Authored by atul on Thu, Apr 11, 8:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 4:51 AM
Unknown Object (File)
Fri, Apr 26, 8:19 PM
Unknown Object (File)
Fri, Apr 26, 2:11 PM
Unknown Object (File)
Fri, Apr 26, 11:47 AM
Unknown Object (File)
Sun, Apr 21, 8:50 AM
Unknown Object (File)
Sun, Apr 21, 5:01 AM
Unknown Object (File)
Thu, Apr 18, 4:34 PM
Unknown Object (File)
Wed, Apr 17, 8:18 AM
View All 12 Files
Subscribers
ashoat

Details

Reviewers
ginsu
tomek
varun
will
Commits
rCOMM702489595a59: [lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData`…
Summary

Pretty straightforward, the UpdateFarcasterMessageData variant includes creatorFID and targetFID.

Considered something like

+userIDsToFID: { +[userID: string]: string },

for consistency with FarcasterRelationshipRequest, but think this approach is cleaner and we don't need validators/etc to ensure that there are only two entries in userIDsToFID, etc.

Depends on D11624

Test Plan

flow + CI

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Thu, Apr 11, 8:05 PM
Herald added a subscriber: ashoat. · View Herald TranscriptThu, Apr 11, 8:05 PM
atul published this revision for review.Thu, Apr 11, 8:06 PM
atul edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B28181: Diff 39070.Thu, Apr 11, 8:21 PM
atul added a child revision: D11642: [lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate[Traditional/Farcaster]RelationshipMessageInfoValidator`.Thu, Apr 11, 8:42 PM
tomek accepted this revision.Fri, Apr 12, 2:39 AM
tomek added inline comments.
lib/types/messages/update-relationship.js
15–24 ↗(On Diff #39070)
This revision is now accepted and ready to land.Fri, Apr 12, 2:39 AM
atul added inline comments.Wed, Apr 17, 12:37 PM
lib/types/messages/update-relationship.js
15–24 ↗(On Diff #39070)

Thanks for catching this!

atul updated this revision to Diff 39197.Wed, Apr 17, 12:40 PM

address @tomek's feedback

atul added a comment.Wed, Apr 17, 12:41 PM

This is safe to land since we don't have equivalent to https://github.com/CommE2E/comm/commit/7024301fcda748efefa900bd952cd8e127aac87d landed on master yet so these messages aren't currently getting created.

This revision was landed with ongoing or failed builds.Wed, Apr 17, 12:42 PM
Closed by commit rCOMM702489595a59: [lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData`… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM702489595a59: [lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData`….
Harbormaster completed remote builds in B28275: Diff 39197.Wed, Apr 17, 1:04 PM

Revision Contents
Changeset List

PathSize
lib/
types/
messages/
25 lines

Diff 39198

View Options

lib/types/messages/update-relationship.js

Loading...