Page MenuHomePhabricator
Differential D11607

[keyserver] Update `createPersonalThreads` to support both `[Traditional/Farcaster]RelationshipRequest`
ClosedPublic
Actions

Authored by atul on Tue, Apr 9, 9:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 3:23 PM
Unknown Object (File)
Fri, Apr 26, 12:18 PM
Unknown Object (File)
Mon, Apr 22, 6:31 PM
Unknown Object (File)
Sun, Apr 21, 6:13 PM
Unknown Object (File)
Sun, Apr 21, 3:26 PM
Unknown Object (File)
Sun, Apr 21, 1:47 PM
Unknown Object (File)
Wed, Apr 17, 4:53 PM
Unknown Object (File)
Tue, Apr 16, 3:27 PM
View All 18 Files
Subscribers
ashoat

Details

Reviewers
ginsu
varun
tomek
will
Commits
rCOMMef12de0da55f: [keyserver] Update `createPersonalThreads` to support both `…
Summary

Now that we may get userIDsToFID instead of userIDs, we need to transform back to list of userIDs via Object.keys to maintain existing behavior.

Depends on D11606

Test Plan
  1. Set breakpoints and add log statements to ensure that userIDs gets constructed as expected for both traditional and farcaster relationship requests.
  2. Check keyserverDB to ensure that threads are created as expected

(need to go through again before landing)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Tue, Apr 9, 9:17 PM
Herald added a subscriber: ashoat. · View Herald TranscriptTue, Apr 9, 9:17 PM
atul updated this revision to Diff 38966.Tue, Apr 9, 9:21 PM

fix import

Harbormaster failed remote builds in B28108: Diff 38964!Tue, Apr 9, 9:33 PM
Harbormaster completed remote builds in B28110: Diff 38966.Tue, Apr 9, 9:38 PM
atul requested review of this revision.Tue, Apr 9, 9:38 PM
atul added a child revision: D11609: [lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action.Tue, Apr 9, 9:41 PM
tomek accepted this revision.Wed, Apr 10, 6:47 AM
tomek added inline comments.
keyserver/src/updaters/relationship-updaters.js
337–339 ↗(On Diff #38966)

How about checking the type property?

This revision is now accepted and ready to land.Wed, Apr 10, 6:47 AM
atul added inline comments.Wed, Apr 10, 12:18 PM
keyserver/src/updaters/relationship-updaters.js
337–339 ↗(On Diff #38966)

Tried this initially, but flow wasn't able to figure out that FARCASTER_MUTUAL requests have userIDsToFID and the rest have userIDs

3cf86a.png (1×2 px, 656 KB)

atul updated this revision to Diff 39005.Wed, Apr 10, 12:18 PM

rebasing stack

atul attached a referenced file: F1510994: 3cf86a.png. (Show Details)Wed, Apr 10, 12:18 PM
Harbormaster completed remote builds in B28137: Diff 39005.Wed, Apr 10, 12:34 PM
atul added a comment.Wed, Apr 17, 12:04 PM

This diff is safe to land as is as it broadens what arguments createPersonalThreads can accept and TraditionalRelationshipRequests will continue to work as expected.

atul updated this revision to Diff 39194.Wed, Apr 17, 12:08 PM

rebase and land

This revision was landed with ongoing or failed builds.Wed, Apr 17, 12:10 PM
Closed by commit rCOMMef12de0da55f: [keyserver] Update `createPersonalThreads` to support both `… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMef12de0da55f: [keyserver] Update `createPersonalThreads` to support both `….
Harbormaster completed remote builds in B28273: Diff 39194.Wed, Apr 17, 12:32 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
updaters/
11 lines

Diff 39195

View Options

keyserver/src/updaters/relationship-updaters.js

Loading...