atul (Atul)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since: Dec 29 2020, 8:08 PM (172 w, 3 d)
Roles: Administrator

FS_JGHeXwAEZWmZ.jpg (700×500 px, 54 KB)

FS_JGHgXwAAsCf2.jpg (700×500 px, 46 KB)

FS_JGHdWYAEPW_t.jpg (700×500 px, 54 KB)

FS_JGHdXwAMHbdF.jpg (700×500 px, 53 KB)

Recent Activity
View All

Today

atul accepted D11683: [native] implement UI for selecting a farcaster channel.

Fri, Apr 19, 2:01 PM

atul closed D11681: [keyserver] Remove `UPDATE_RELATIONSHIP.farcaster_mutual` messages from KeyserverDB.

Fri, Apr 19, 11:56 AM

atul committed rCOMMfd6440e367d5: [keyserver] Remove `UPDATE_RELATIONSHIP.farcaster_mutual` messages from… (authored by atul).

[keyserver] Remove `UPDATE_RELATIONSHIP.farcaster_mutual` messages from…

Fri, Apr 19, 11:56 AM

atul updated the diff for D11681: [keyserver] Remove `UPDATE_RELATIONSHIP.farcaster_mutual` messages from KeyserverDB.

rebase and land

Fri, Apr 19, 11:49 AM

atul closed D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.

Fri, Apr 19, 11:41 AM

atul committed rCOMM6a7fc7095ba9: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages (authored by atul).

[web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages

Fri, Apr 19, 11:41 AM

atul updated the diff for D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.

rebase and alnd

Fri, Apr 19, 11:40 AM

atul closed D11669: [native] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.

Fri, Apr 19, 11:37 AM

atul committed rCOMMbf26a3ce015a: [native] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages (authored by atul).

[native] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages

Fri, Apr 19, 11:37 AM

atul updated the diff for D11669: [native] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.

rebase and land

Fri, Apr 19, 11:23 AM

Yesterday

atul added a comment to D11681: [keyserver] Remove `UPDATE_RELATIONSHIP.farcaster_mutual` messages from KeyserverDB.

@ashoat, would it make sense to backup prod DB before deploying this migration to keyserver as a precaution?

Thu, Apr 18, 1:46 PM

atul added inline comments to D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.

Thu, Apr 18, 1:41 PM

atul updated the diff for D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.

fix typo + remove second invaraint

Thu, Apr 18, 1:40 PM

atul updated the diff for D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.

get rid of first invariant

Thu, Apr 18, 1:38 PM

atul attached a referenced file: F1574319: fbacb2.png.

Thu, Apr 18, 1:37 PM

atul attached a referenced file: F1574322: 3f0434.png.

Thu, Apr 18, 1:37 PM

atul added inline comments to D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.

Thu, Apr 18, 1:37 PM

atul closed D11624: [lib] Fix `farcasterRelationshipRequestValidator`.

Thu, Apr 18, 1:26 PM

atul committed rCOMM003bf69d1b44: [lib] Fix `farcasterRelationshipRequestValidator` (authored by atul).

[lib] Fix `farcasterRelationshipRequestValidator`

Thu, Apr 18, 1:26 PM

atul closed D11612: [lib] Update `updateRelationshipInputValidator` to be union of `[traditional/farcaster]RelationshipRequestValidator`.

Thu, Apr 18, 1:26 PM

atul closed D11611: [keyserver] Update `updateRelationshipsResponder` to handle `RelationshipRequest`.

Thu, Apr 18, 1:26 PM

atul committed rCOMM811b86e47c66: [lib] Update `updateRelationshipInputValidator` to be union of `… (authored by atul).

[lib] Update `updateRelationshipInputValidator` to be union of `…

Thu, Apr 18, 1:26 PM

atul committed rCOMMa4d6f0cb4057: [keyserver] Update `updateRelationshipsResponder` to handle… (authored by atul).

[keyserver] Update `updateRelationshipsResponder` to handle…

Thu, Apr 18, 1:26 PM

atul closed D11610: [keyserver] Narrow `updateRelationshipInputValidator` to exclude `farcaster` action.

Thu, Apr 18, 1:26 PM

atul closed D11609: [lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action.

Thu, Apr 18, 1:26 PM

atul committed rCOMM8eef17ad3a41: [keyserver] Narrow `updateRelationshipInputValidator` to exclude `farcaster`… (authored by atul).

[keyserver] Narrow `updateRelationshipInputValidator` to exclude `farcaster`…

Thu, Apr 18, 1:26 PM

atul committed rCOMM1638313148ad: [lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action (authored by atul).

[lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action

Thu, Apr 18, 1:26 PM

atul closed D11606: [lib] Update `FarcasterDataHandler` to construct `FarcasterRelationshipRequest` with `userIDsToFID`.

Thu, Apr 18, 1:26 PM

atul committed rCOMM6e98c6bfd206: [lib] Update `FarcasterDataHandler` to construct `FarcasterRelationshipRequest`… (authored by atul).

[lib] Update `FarcasterDataHandler` to construct `FarcasterRelationshipRequest`…

Thu, Apr 18, 1:26 PM

atul updated the diff for D11624: [lib] Fix `farcasterRelationshipRequestValidator`.

rebase and land

Thu, Apr 18, 1:21 PM

atul updated the diff for D11612: [lib] Update `updateRelationshipInputValidator` to be union of `[traditional/farcaster]RelationshipRequestValidator`.

rebase and alnd

Thu, Apr 18, 1:21 PM

atul updated the diff for D11611: [keyserver] Update `updateRelationshipsResponder` to handle `RelationshipRequest`.

rebase and land

Thu, Apr 18, 1:21 PM

atul updated the diff for D11610: [keyserver] Narrow `updateRelationshipInputValidator` to exclude `farcaster` action.

rebase and land

Thu, Apr 18, 1:20 PM

atul updated the diff for D11609: [lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action.

rebase and land

Thu, Apr 18, 1:20 PM

atul updated the diff for D11606: [lib] Update `FarcasterDataHandler` to construct `FarcasterRelationshipRequest` with `userIDsToFID`.

rebase and land

Thu, Apr 18, 1:20 PM

atul added a comment to D11624: [lib] Fix `farcasterRelationshipRequestValidator`.

In D11624#334284, @tomek wrote:

Do we need a dedicated validator for UpdateRelationshipMessage?

Thu, Apr 18, 1:19 PM

atul added inline comments to D11610: [keyserver] Narrow `updateRelationshipInputValidator` to exclude `farcaster` action.

Thu, Apr 18, 1:18 PM

atul closed D11653: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromClientDB` to handle `farcaster_mutual`.

Thu, Apr 18, 1:11 PM

atul committed rCOMM1bae5d5e9484: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromClientDB` to handle… (authored by atul).

[lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromClientDB` to handle…

Thu, Apr 18, 1:11 PM

atul updated the diff for D11653: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromClientDB` to handle `farcaster_mutual`.

land

Thu, Apr 18, 1:09 PM

atul closed D11652: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromServerDB` to handle `farcaster_mutual`.

Thu, Apr 18, 1:05 PM

atul committed rCOMM0b125c91012d: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromServerDB` to handle… (authored by atul).

[lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromServerDB` to handle…

Thu, Apr 18, 1:05 PM

atul updated the diff for D11652: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromServerDB` to handle `farcaster_mutual`.

land

Thu, Apr 18, 1:05 PM

atul closed D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual`.

Thu, Apr 18, 12:38 PM

atul committed rCOMM06f7b1904d97: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update… (authored by atul).

[lib] Include `[creator/target]FID` in `messageContentForServerDB` when update…

Thu, Apr 18, 12:38 PM

atul added inline comments to D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual`.

Thu, Apr 18, 12:37 PM

atul added inline comments to D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual`.

Thu, Apr 18, 11:50 AM

atul closed D11650: [lib] Split `UpdateRelationshipMessageInfo` into `Update[Traditional/Farcaster]RelationshipMessageInfo`.

Thu, Apr 18, 11:48 AM

atul committed rCOMM7996b0306372: [lib] Split `UpdateRelationshipMessageInfo` into `Update… (authored by atul).

[lib] Split `UpdateRelationshipMessageInfo` into `Update…

Thu, Apr 18, 11:48 AM

atul attached a referenced file: F1520661: 8c0f7f.png.

Thu, Apr 18, 11:43 AM

atul updated the diff for D11650: [lib] Split `UpdateRelationshipMessageInfo` into `Update[Traditional/Farcaster]RelationshipMessageInfo`.

rebase and aldn

Thu, Apr 18, 11:43 AM

atul attached a referenced file: F1572505: 158a3d.png.

Thu, Apr 18, 11:39 AM

atul added inline comments to D11650: [lib] Split `UpdateRelationshipMessageInfo` into `Update[Traditional/Farcaster]RelationshipMessageInfo`.

Thu, Apr 18, 11:07 AM

atul added inline comments to D11650: [lib] Split `UpdateRelationshipMessageInfo` into `Update[Traditional/Farcaster]RelationshipMessageInfo`.

Thu, Apr 18, 11:05 AM

Wed, Apr 17

atul closed D11642: [lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate[Traditional/Farcaster]RelationshipMessageInfoValidator`.

Wed, Apr 17, 1:17 PM

atul committed rCOMMa1d401813b70: [lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate… (authored by atul).

[lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate…

Wed, Apr 17, 1:17 PM

atul updated the diff for D11642: [lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate[Traditional/Farcaster]RelationshipMessageInfoValidator`.

address feedback and land

Wed, Apr 17, 1:10 PM

atul updated the diff for D11642: [lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate[Traditional/Farcaster]RelationshipMessageInfoValidator`.

rebase BEFORE addressing feedback

Wed, Apr 17, 12:58 PM

atul closed D11641: [lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData` and `UpdateFarcasterMessageData`.

Wed, Apr 17, 12:42 PM

atul committed rCOMM702489595a59: [lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData`… (authored by atul).

[lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData`…

Wed, Apr 17, 12:42 PM

atul added a comment to D11641: [lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData` and `UpdateFarcasterMessageData`.

This is safe to land since we don't have equivalent to https://github.com/CommE2E/comm/commit/7024301fcda748efefa900bd952cd8e127aac87d landed on master yet so these messages aren't currently getting created.

Wed, Apr 17, 12:41 PM

atul updated the diff for D11641: [lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData` and `UpdateFarcasterMessageData`.

address @tomek's feedback

Wed, Apr 17, 12:40 PM

atul added inline comments to D11641: [lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData` and `UpdateFarcasterMessageData`.

Wed, Apr 17, 12:37 PM

atul added a comment to D11609: [lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action.

JK, we need D11606 to land this

Wed, Apr 17, 12:24 PM

atul updated the diff for D11609: [lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action.

rebase and land

Wed, Apr 17, 12:15 PM

atul added a comment to D11609: [lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action.

This diff is safe to land since we're just narrowing flow types on the clients. No runtime changes so this shouldn't break anything.

Wed, Apr 17, 12:13 PM

atul closed D11607: [keyserver] Update `createPersonalThreads` to support both `[Traditional/Farcaster]RelationshipRequest`.

Wed, Apr 17, 12:10 PM

atul committed rCOMMef12de0da55f: [keyserver] Update `createPersonalThreads` to support both `… (authored by atul).

[keyserver] Update `createPersonalThreads` to support both `…

Wed, Apr 17, 12:10 PM

atul updated the diff for D11607: [keyserver] Update `createPersonalThreads` to support both `[Traditional/Farcaster]RelationshipRequest`.

rebase and land

Wed, Apr 17, 12:08 PM

atul added a comment to D11607: [keyserver] Update `createPersonalThreads` to support both `[Traditional/Farcaster]RelationshipRequest`.

This diff is safe to land as is as it broadens what arguments createPersonalThreads can accept and TraditionalRelationshipRequests will continue to work as expected.

Wed, Apr 17, 12:04 PM

atul published D11681: [keyserver] Remove `UPDATE_RELATIONSHIP.farcaster_mutual` messages from KeyserverDB for review.

Wed, Apr 17, 11:55 AM

atul updated the test plan for D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.

Wed, Apr 17, 11:18 AM

atul attached a referenced file: F1559388: 6e04a6.png.

Wed, Apr 17, 11:16 AM

atul published D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages for review.

Wed, Apr 17, 11:16 AM

atul accepted D11672: create new aux user store action for clearing fids.

Looks good

Wed, Apr 17, 9:37 AM

atul added inline comments to D11669: [native] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.

Wed, Apr 17, 9:35 AM

Tue, Apr 16

atul updated the diff for D11669: [native] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.

remove hack from stack

Tue, Apr 16, 12:43 PM

atul published D11669: [native] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages for review.

Tue, Apr 16, 12:27 PM

atul updated the summary of D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual`.

Tue, Apr 16, 12:22 PM

atul accepted D11665: [web] convert updating thread activity `lastThreadNavigatedTo` on web to use sqlite.

Tue, Apr 16, 11:35 AM

atul added inline comments to D11667: [lib] Fix legacy register and SIWE.

Tue, Apr 16, 11:33 AM

atul accepted D11667: [lib] Fix legacy register and SIWE.

Tue, Apr 16, 11:31 AM

atul updated the diff for D11642: [lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate[Traditional/Farcaster]RelationshipMessageInfoValidator`.

fix TUnion import

Tue, Apr 16, 10:51 AM

Mon, Apr 15

atul accepted D11662: [native] introduce barebones TagFarcasterChannelNavigator + TagFarcasterChannel screen.

Looks good, let's definitely memoize return value of TagFarcasterChannelNavigator.

Mon, Apr 15, 4:36 PM

atul accepted D11613: [lib/native] introduce connect farcaster alert handler.

Code changes look good, would be good to make sure all other notes left by other reviewers are addressed/responded to before landing.

Mon, Apr 15, 4:33 PM

Fri, Apr 12

atul published D11653: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromClientDB` to handle `farcaster_mutual` for review.

Fri, Apr 12, 1:12 PM

atul published D11652: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromServerDB` to handle `farcaster_mutual` for review.

Fri, Apr 12, 12:59 PM

atul updated the test plan for D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual`.

Fri, Apr 12, 12:27 PM

atul published D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual` for review.

Fri, Apr 12, 12:26 PM

atul requested review of D11650: [lib] Split `UpdateRelationshipMessageInfo` into `Update[Traditional/Farcaster]RelationshipMessageInfo`.

Fri, Apr 12, 12:03 PM

Thu, Apr 11

atul requested review of D11642: [lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate[Traditional/Farcaster]RelationshipMessageInfoValidator`.

Thu, Apr 11, 8:58 PM

atul published D11641: [lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData` and `UpdateFarcasterMessageData` for review.

Thu, Apr 11, 8:06 PM

atul accepted D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.

Thu, Apr 11, 6:53 PM

atul accepted D11637: Implement JSI getter and setter for siwe backup secrets.

Looks good. (There shouldn't be any WASM stuff that needs to be generated for the non-DB code here right?)

Thu, Apr 11, 6:42 PM

atul added a comment to D11636: Implement screen to create backup mesage and its signature.

Would also be good to include some screenshots of what it looks like in Test Plan so reviewers can side-by-side with the Figma designs

Thu, Apr 11, 6:38 PM

atul added a reviewer for D11636: Implement screen to create backup mesage and its signature: ginsu.

Thu, Apr 11, 6:38 PM

atul accepted D11636: Implement screen to create backup mesage and its signature.

Thu, Apr 11, 6:37 PM

atul accepted D11635: Handle backup message type with different user texts in siwe.reac.js.

Thu, Apr 11, 6:25 PM

atul accepted D11628: [lib] Make synced metadata name field an enum.

Thu, Apr 11, 6:21 PM

atul accepted D11627: Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear.

Thu, Apr 11, 6:18 PM