iOS error is unrelated. Created ENG-8036 to track
Active Repositories
Active Repositories
- rCOMM Comm
- Thu, May 2, 11:03 AM2024-05-02 11:03:18 (UTC-7)
- Git
Recent Activity
Recent Activity
Today
Today
ashoat added a comment to D11862: [native] Check if Farcaster account is already linked in FarcasterWebView.
ashoat requested review of D11862: [native] Check if Farcaster account is already linked in FarcasterWebView.
varun requested review of D11861: [native_rust_library] refactor helper structs to avoid duplication.
varun added inline comments to D11860: [web] differentiate between password and wallet users in MissingCSATModal.
ashoat added inline comments to D11860: [web] differentiate between password and wallet users in MissingCSATModal.
ashoat added a comment to D11707: [keyserver] Send farcaster_mutual UPDATE_RELATIONSHIP message when establishing Farcaster relationship.
I haven't landed this yet because I'm having trouble testing it while tethering and don't have access to Wi-Fi right now. Will hopefully find some Wi-Fi tomorrow
varun requested review of D11860: [web] differentiate between password and wallet users in MissingCSATModal.
iOS build failure looks unrelated
In D11852#339861, @varun wrote:I was imagining that all the prefixes (e.g. DB Error) would be defined in a module in constants.rs and then used like this:
pub const DB_ERROR_LOG_PREFIX: &str = "DB Error"; error!(DB_ERROR_LOG_PREFIX, "Encountered an unexpected error: {}", e);
Saw this on the doc:
i think @bartek should take a look when he's back
I was imagining that all the prefixes (e.g. DB Error) would be defined in a module in constants.rs and then used like this:
atul committed rCOMM50a37eef69e4: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[lib] Replace `threadHasPermission` with `useThreadHasPermission` in…
atul updated the diff for D11817: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanCreateSidebarFromMessage`.
land
atul committed rCOMMbf7178f18877: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[lib] Replace `threadHasPermission` with `useThreadHasPermission` in…
In D11858#339835, @ashoat wrote:It looks like @marcin's investigation has shown that ChatGPT is wrong, and he is pursuing a different theory that perhaps Android is punishing us for sending non-visual notifs (rescind and badge-only) with high priority. I think this is a good direction to explore.
I think ChatGPT was right about setting android: {priority: 'high'} - I just found that this is already handled by firebase-admin. I think that setting priority to high (which we are currently doing) for badge updates and rescinds might be a mistake based on this docs: https://firebase.google.com/docs/cloud-messaging/concept-options#setting-the-priority-of-a-message
atul updated the diff for D11816: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanEditMessage`.
address feedback
- I don't think SubmitButton is a great name for this. It's used for actions other than submitting.
- I don't think it makes sense to move this component out by itself. It's tightly coupled to the other visual components in the native/account/registration folder, and now it's pretty weird that some of them are in that folder and some are elsewhere.
It looks like @marcin's investigation has shown that ChatGPT is wrong, and he is pursuing a different theory that perhaps Android is punishing us for sending non-visual notifs (rescind and badge-only) with high priority. I think this is a good direction to explore.
ashoat committed rCOMMf2ff6eee2e29: [native] Prevent user from leaving RegistrationTerms during registration request (authored by ashoat).
[native] Prevent user from leaving RegistrationTerms during registration request
ashoat committed rCOMM6778c6805b7e: [lib][native] Automatically retry keyserverAuth during login/registration (authored by ashoat).
[lib][native] Automatically retry keyserverAuth during login/registration
ashoat committed rCOMMd94e8201ccc7: [native] Show "unknown error" alert if keyserver auth fails during registration (authored by ashoat).
[native] Show "unknown error" alert if keyserver auth fails during registration
ashoat committed rCOMMe27a6dfb78f0: [lib][native][web] Wait until database deletion before rejecting… (authored by ashoat).
[lib][native][web] Wait until database deletion before rejecting…
ashoat committed rCOMM39314e76eb6f: [lib][native] Reset login state if authoritative keyserver fails (authored by ashoat).
[lib][native] Reset login state if authoritative keyserver fails
Oh wait, there are updates on Linear I missed. Let me read them first, sorry for missing that