User Details
User Details
- User Since
- Aug 23 2022, 10:29 AM (88 w, 2 d)
Today
Today
Yesterday
Yesterday
ginsu requested review of D11857: [native] implement UI for TagUnfollowedFarcasterChannel screen.
ginsu requested review of D11856: [native] refactor registration button to be submit button.
ginsu committed rCOMMa7783725d1fd: [lib] introduce useDeleteFarcasterChannelTag (authored by ginsu).
[lib] introduce useDeleteFarcasterChannelTag
ginsu committed rCOMMffc0c01586ef: [keyserver/lib] introduce delete_farcaster_channel_tag endpoint (authored by ginsu).
[keyserver/lib] introduce delete_farcaster_channel_tag endpoint
ginsu committed rCOMMdd631917b6ec: [lib] introduce deleteFarcasterChannelTagActionTypes (authored by ginsu).
[lib] introduce deleteFarcasterChannelTagActionTypes
ginsu committed rCOMMa6d188d1ca79: [keyserver] introduce deleteFarcasterChannelTag (authored by ginsu).
[keyserver] introduce deleteFarcasterChannelTag
ginsu updated the diff for D11821: [lib] introduce useDeleteFarcasterChannelTag.
rebase before landing
ginsu added inline comments to D11821: [lib] introduce useDeleteFarcasterChannelTag.
ginsu updated the diff for D11815: [lib] introduce deleteFarcasterChannelTagActionTypes.
rebase before landing
ginsu added inline comments to D11815: [lib] introduce deleteFarcasterChannelTagActionTypes.
ginsu updated the diff for D11814: [keyserver/lib] introduce delete_farcaster_channel_tag endpoint.
address comments + rebase before landing
ginsu updated the diff for D11813: [keyserver] introduce deleteFarcasterChannelTag.
address comments + rebase before landing
ginsu added inline comments to D11813: [keyserver] introduce deleteFarcasterChannelTag.
Tue, Apr 30
Tue, Apr 30
ginsu committed rCOMM57c01e17a94d: [native] show error message for tag farcaster channel errors (authored by ginsu).
[native] show error message for tag farcaster channel errors
[native] introduce tag farcaster button
ginsu added a comment to D11809: [native] show error message for tag farcaster channel errors.
Thought about whether we could filter the list of channels before it gets to the keyserver, but we'd probably need a UI to show which ones are already taken, in addition to logic on the client to check each channel with the blob service. Probably too much additional complexity to be worth doing at this time
ginsu updated the diff for D11809: [native] show error message for tag farcaster channel errors.
address comments + rebase before landing
ginsu updated the diff for D11793: [native] introduce tag farcaster button.
rebase before landing
Mon, Apr 29
Mon, Apr 29
ginsu committed rCOMM4ba9c88fe604: [native] introduce TagFarcasterChannelParams (authored by ginsu).
[native] introduce TagFarcasterChannelParams
ginsu committed rCOMM7cf5ed482dfa: [native] update selectedChannel state to be a FarcasterChannel type (authored by ginsu).
[native] update selectedChannel state to be a FarcasterChannel type
ginsu committed rCOMM4a840575c115: [lib] move farcaster types to dedicated file (authored by ginsu).
[lib] move farcaster types to dedicated file
ginsu committed rCOMMc23a318c9bbc: [lib] introduce useCreateOrUpdateFarcasterChannelTag (authored by ginsu).
[lib] introduce useCreateOrUpdateFarcasterChannelTag
ginsu committed rCOMM46cdf8d6b793: [lib] introduce createOrUpdateFarcasterChannelTagActionTypes (authored by ginsu).
[lib] introduce createOrUpdateFarcasterChannelTagActionTypes
ginsu committed rCOMM15bbe7ca3728: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint (authored by ginsu).
[keyserver] introduce create_or_update_farcaster_channel_tag endpoint
ginsu committed rCOMM5d8c30d8715a: [keysever/lib/native] introduce gate for tagging farcaster channel work (authored by ginsu).
[keysever/lib/native] introduce gate for tagging farcaster channel work
ginsu updated the diff for D11785: [native] introduce TagFarcasterChannelParams.
rebase before landing
ginsu updated the diff for D11784: [native] update selectedChannel state to be a FarcasterChannel type.
rebase before landing
ginsu updated the diff for D11776: [lib] move farcaster types to dedicated file.
rebase before landing
ginsu updated the diff for D11775: [lib] introduce useCreateOrUpdateFarcasterChannelTag.
rebase before landing
ginsu updated the diff for D11774: [lib] introduce createOrUpdateFarcasterChannelTagActionTypes.
rebase before landing
ginsu updated the diff for D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
rebase before landing
ginsu added a comment to D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
Going to land this diff now, but overall agree with the feedback regarding that reviewing this work would be easier to follow if I initially sequenced the work better. Will make sure that next time I introduce endpoints or work more in the keyserver code I think more critically on this.
ginsu updated the diff for D11808: [keysever/lib/native] introduce gate for tagging farcaster channel work.
address comments
Fri, Apr 26
Fri, Apr 26
ginsu requested review of D11821: [lib] introduce useDeleteFarcasterChannelTag.
ginsu requested review of D11815: [lib] introduce deleteFarcasterChannelTagActionTypes.
ginsu requested review of D11814: [keyserver/lib] introduce delete_farcaster_channel_tag endpoint.
ginsu requested review of D11813: [keyserver] introduce deleteFarcasterChannelTag.
ginsu requested review of D11809: [native] show error message for tag farcaster channel errors.
ginsu requested review of D11808: [keysever/lib/native] introduce gate for tagging farcaster channel work.
ginsu added inline comments to D11793: [native] introduce tag farcaster button.
ginsu added inline comments to D11793: [native] introduce tag farcaster button.
ginsu updated the diff for D11793: [native] introduce tag farcaster button.
update createCreateOrUpdateActionPromise to return the response
ginsu requested review of D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
In D11808, we gate the entire endpoint and this should address the concerns regarding exposing the endpoint w/o permissions +ensuring that nobody will ever have a blob holder on their client
ginsu updated the summary of D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
Thu, Apr 25
Thu, Apr 25
Adding @ashoat as a blocking reviewer since there are copy changes in this diff
ginsu attached a referenced file: F1664658: Screen Recording 2024-04-25 at 7.13.48 PM.mov.
ginsu updated the summary of D11793: [native] introduce tag farcaster button.
ginsu requested review of D11793: [native] introduce tag farcaster button.
alert code looks good, pls make sure to respond + address @ashoat's comments before landing
ginsu requested review of D11785: [native] introduce TagFarcasterChannelParams.
ginsu requested review of D11784: [native] update selectedChannel state to be a FarcasterChannel type.
ginsu committed rCOMM5a19bd32d3c4: [keyserver] introduce barebones createOrUpdateFarcasterChannelTag (authored by ginsu).
[keyserver] introduce barebones createOrUpdateFarcasterChannelTag
ginsu updated the diff for D11772: [keyserver] introduce barebones createOrUpdateFarcasterChannelTag.
rebase before landing
ginsu added inline comments to D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
ginsu attached a referenced file: F1663812: Screenshot 2024-04-25 at 2.53.02 PM.png.
ginsu added inline comments to D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
ginsu added inline comments to D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
Wed, Apr 24
Wed, Apr 24
ginsu requested review of D11776: [lib] move farcaster types to dedicated file.
ginsu requested review of D11775: [lib] introduce useCreateOrUpdateFarcasterChannelTag.
ginsu requested review of D11774: [lib] introduce createOrUpdateFarcasterChannelTagActionTypes.
ginsu requested review of D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
ginsu requested review of D11772: [keyserver] introduce barebones createOrUpdateFarcasterChannelTag.
Mon, Apr 22
Mon, Apr 22
ginsu committed rCOMM780b38b899e3: [native] implement UI for selecting a farcaster channel (authored by ginsu).
[native] implement UI for selecting a farcaster channel
ginsu attached a referenced file: F1632875: Screenshot 2024-04-22 at 1.58.30 PM.png.
ginsu updated the diff for D11683: [native] implement UI for selecting a farcaster channel.
address comments
ginsu added inline comments to D11683: [native] implement UI for selecting a farcaster channel.
Fri, Apr 19
Fri, Apr 19
let's goooo
Thu, Apr 18
Thu, Apr 18
[lib/web] fix error handling indirection
ginsu updated the diff for D11689: [lib/web] fix error handling indirection.
rebase before landing
ginsu updated the test plan for D11689: [lib/web] fix error handling indirection.
ginsu requested review of D11689: [lib/web] fix error handling indirection.
ginsu committed rCOMM409e47a1b60b: [native] introduce screen options to tag farcaster channel stack navigator (authored by ginsu).
[native] introduce screen options to tag farcaster channel stack navigator
ginsu added inline comments to D11683: [native] implement UI for selecting a farcaster channel.
ginsu added inline comments to D11683: [native] implement UI for selecting a farcaster channel.
ginsu added inline comments to D11683: [native] implement UI for selecting a farcaster channel.
ginsu committed rCOMMfa258611a1ef: [native] introduce barebones TagFarcasterChannelNavigator + TagFarcasterChannel… (authored by ginsu).
[native] introduce barebones TagFarcasterChannelNavigator + TagFarcasterChannel…
ginsu updated the diff for D11662: [native] introduce barebones TagFarcasterChannelNavigator + TagFarcasterChannel screen.
rebase before landing
ginsu committed rCOMMb9c03cdb74fb: [lib] introduce fetchFollowedFarcasterChannels to neynar client class (authored by ginsu).
[lib] introduce fetchFollowedFarcasterChannels to neynar client class