Handle backup message type with different user texts in siwe.reac.js
ClosedPublic
Actions

Authored by marcin on Thu, Apr 11, 9:01 AM.

Details

Reviewers

tomek
atul
inka

Commits

rCOMMd0736e8e1ee0: Handle backup message type with different user texts in siwe.reac.js

Summary

This differential modifies SIWE component so that it renders different user texts based on the type of message we want to sign.

Test Plan

It may sound a little strange:

Modify fullscreen-siwe-panel.react.js/connect-ethereum.react.js to provide SIWEMEssageTypes.MSG_BACKUP instead of MSG_AUTH.
Attempt/log in registration process.
Ensure that log in/registration is succesfull but the texts that are displayed refer to backup message generation.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Thu, Apr 11, 9:01 AM

Herald added a subscriber: ashoat. · View Herald TranscriptThu, Apr 11, 9:01 AM

marcin added a parent revision: D11634: Introduce user texts for siwe backup message creation.Thu, Apr 11, 9:03 AM

marcin added a child revision: D11636: Implement screen to create backup mesage and its signature.Thu, Apr 11, 9:08 AM

Harbormaster completed remote builds in B28173: Diff 39060.Thu, Apr 11, 9:21 AM

marcin requested review of this revision.Thu, Apr 11, 9:21 AM

atul accepted this revision.Thu, Apr 11, 6:25 PM

atul added inline comments.

landing/siwe.react.js
128–134 ↗	(On Diff #39060)	This is relevant both for backup flow and auth flow, right? Just want not make sure this early return won't break anything for auth
135–140 ↗	(On Diff #39060)	Guessing backup flow also requires `nonce` since it's still a SIWE message(?), so this won't break anything

This revision is now accepted and ready to land.Thu, Apr 11, 6:25 PM

Would be good to include screenshots of what the various screens look like from mobile. (You can omit the original screen if it's unchanged.)

marcin added inline comments.Mon, Apr 15, 3:44 AM

landing/siwe.react.js
128–134 ↗	(On Diff #39060)	Yes - as we introduced type for both backup and auth the auth flow also needs to provide this parameter. I added it explicitly in each place that performs SIWE auth.
135–140 ↗	(On Diff #39060)	Yes - the only thing in which backup and auth differ are user texts. The rest of the flow - including message format - are the same.

In D11635#334580, @ashoat wrote:

Would be good to include screenshots of what the various screens look like from mobile. (You can omit the original screen if it's unchanged.)

Included in D11636