Page MenuHomePhabricator
Feed Advanced Search

Yesterday

atul closed D11817: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanCreateSidebarFromMessage`.
Thu, May 2, 11:03 AM
atul committed rCOMM50a37eef69e4: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[lib] Replace `threadHasPermission` with `useThreadHasPermission` in…
Thu, May 2, 11:03 AM
atul updated the diff for D11817: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanCreateSidebarFromMessage`.

land

Thu, May 2, 10:52 AM
atul closed D11816: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanEditMessage`.
Thu, May 2, 9:59 AM
atul committed rCOMMbf7178f18877: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[lib] Replace `threadHasPermission` with `useThreadHasPermission` in…
Thu, May 2, 9:59 AM
atul updated the diff for D11816: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanEditMessage`.

address feedback

Thu, May 2, 9:47 AM

Wed, May 1

atul closed D11712: [lib] Shim unsupported messages for `web`/`desktop`.
Wed, May 1, 4:54 PM
atul committed rCOMM4c5a86dbda62: [lib] Shim unsupported messages for `web`/`desktop` (authored by atul).
[lib] Shim unsupported messages for `web`/`desktop`
Wed, May 1, 4:54 PM
atul updated the diff for D11712: [lib] Shim unsupported messages for `web`/`desktop`.

rebase and land

Wed, May 1, 4:35 PM
atul added a comment to D11712: [lib] Shim unsupported messages for `web`/`desktop`.

Did testing to ensure UNSUPPORTED messages appear as expected on web client:

Wed, May 1, 4:30 PM

Fri, Apr 26

atul requested review of D11822: [lib] Narrow `canToggleMessagePin` and `useCanToggleMessagePin` types.
Fri, Apr 26, 1:36 PM
atul requested review of D11820: [web] Replace `canToggleMessagePin` with `useCanToggleMessagePin` in `useMessageTogglePinAction`.
Fri, Apr 26, 1:26 PM
atul requested review of D11819: [lib] Introduce `useCanToggleMessagePin` and consume in `native/Message`.
Fri, Apr 26, 1:22 PM
atul requested review of D11818: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanCreateReactionFromMessage`.
Fri, Apr 26, 1:16 PM
atul requested review of D11817: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanCreateSidebarFromMessage`.
Fri, Apr 26, 1:10 PM
atul requested review of D11816: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanEditMessage`.
Fri, Apr 26, 1:07 PM
atul closed D11792: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook.
Fri, Apr 26, 12:13 PM
atul committed rCOMM64ad347fd686: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook (authored by atul).
[lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook
Fri, Apr 26, 12:12 PM
atul updated the diff for D11792: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook.

consolidate conditional

Fri, Apr 26, 12:08 PM
atul added inline comments to D11792: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook.
Fri, Apr 26, 11:47 AM
atul closed D11791: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.
Fri, Apr 26, 11:46 AM
atul closed D11790: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `TextMessage`.
Fri, Apr 26, 11:46 AM
atul committed rCOMM136bd75e5a11: [native] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[native] Replace `threadHasPermission` with `useThreadHasPermission` in…
Fri, Apr 26, 11:46 AM
atul committed rCOMMee863bd9130e: [native] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[native] Replace `threadHasPermission` with `useThreadHasPermission` in…
Fri, Apr 26, 11:46 AM
atul closed D11789: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ChatInputBar`.
Fri, Apr 26, 11:46 AM
atul closed D11788: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`.
Fri, Apr 26, 11:46 AM
atul committed rCOMM44f0eb5b7bb2: [native] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[native] Replace `threadHasPermission` with `useThreadHasPermission` in…
Fri, Apr 26, 11:46 AM
atul committed rCOMM35ac66da12dd: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry` (authored by atul).
[native] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`
Fri, Apr 26, 11:46 AM
atul closed D11786: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ViewInviteLinksScreen`.
Fri, Apr 26, 11:46 AM
atul closed D11787: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `CommunityActionsButton`.
Fri, Apr 26, 11:46 AM
atul committed rCOMMbdb7d7e4f575: [native] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[native] Replace `threadHasPermission` with `useThreadHasPermission` in…
Fri, Apr 26, 11:46 AM
atul committed rCOMM70c6da8e1aab: [native] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[native] Replace `threadHasPermission` with `useThreadHasPermission` in…
Fri, Apr 26, 11:46 AM
atul closed D11754: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.
Fri, Apr 26, 11:46 AM
atul committed rCOMM5c7f9868ce1a: [native] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[native] Replace `threadHasPermission` with `useThreadHasPermission` in…
Fri, Apr 26, 11:45 AM
atul updated the diff for D11791: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.

land

Fri, Apr 26, 11:43 AM
atul updated the diff for D11790: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `TextMessage`.

land

Fri, Apr 26, 11:43 AM
atul updated the diff for D11789: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ChatInputBar`.

land

Fri, Apr 26, 11:43 AM
atul updated the diff for D11788: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`.

land

Fri, Apr 26, 11:07 AM
atul updated the diff for D11787: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `CommunityActionsButton`.

land

Fri, Apr 26, 11:06 AM
atul updated the diff for D11786: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ViewInviteLinksScreen`.

land

Fri, Apr 26, 11:06 AM
atul updated the diff for D11754: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.

land

Fri, Apr 26, 10:55 AM

Thu, Apr 25

atul requested review of D11792: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook.
Thu, Apr 25, 2:30 PM
atul requested review of D11791: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.
Thu, Apr 25, 2:26 PM
atul requested review of D11790: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `TextMessage`.
Thu, Apr 25, 2:21 PM
atul requested review of D11789: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ChatInputBar`.
Thu, Apr 25, 2:15 PM
atul requested review of D11788: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`.
Thu, Apr 25, 2:12 PM
atul requested review of D11787: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `CommunityActionsButton`.
Thu, Apr 25, 2:11 PM
atul requested review of D11786: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ViewInviteLinksScreen`.
Thu, Apr 25, 2:10 PM
atul added a comment to D11754: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.

Will test generally at end to make sure things work as expected.

Is this something that will be done later in the stack?

Thu, Apr 25, 10:13 AM

Wed, Apr 24

atul closed D11752: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `MembersModal`.
Wed, Apr 24, 6:58 PM
atul closed D11751: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `CommunityActionsMenu`.
Wed, Apr 24, 6:58 PM
atul committed rCOMMb6c3358bdf37: [web] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[web] Replace `threadHasPermission` with `useThreadHasPermission` in…
Wed, Apr 24, 6:58 PM
atul closed D11750: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadMenu`.
Wed, Apr 24, 6:58 PM
atul committed rCOMM26e18f854825: [web] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[web] Replace `threadHasPermission` with `useThreadHasPermission` in…
Wed, Apr 24, 6:58 PM
atul committed rCOMM9c19d63b2e5b: [web] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[web] Replace `threadHasPermission` with `useThreadHasPermission` in…
Wed, Apr 24, 6:58 PM
atul closed D11749: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ChatInputBar`.
Wed, Apr 24, 6:58 PM
atul closed D11748: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`.
Wed, Apr 24, 6:58 PM
atul committed rCOMM9b9964fa6b48: [web] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[web] Replace `threadHasPermission` with `useThreadHasPermission` in…
Wed, Apr 24, 6:58 PM
atul committed rCOMM572a486f5101: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry` (authored by atul).
[web] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`
Wed, Apr 24, 6:58 PM
atul closed D11747: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `EditThreadAvatar`.
Wed, Apr 24, 6:58 PM
atul committed rCOMM9f41d12aef51: [web] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).
[web] Replace `threadHasPermission` with `useThreadHasPermission` in…
Wed, Apr 24, 6:58 PM
atul updated the diff for D11752: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `MembersModal`.

rebase and land

Wed, Apr 24, 1:23 PM
atul updated the diff for D11751: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `CommunityActionsMenu`.

land

Wed, Apr 24, 1:23 PM
atul updated the diff for D11750: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadMenu`.

land

Wed, Apr 24, 1:21 PM
atul updated the diff for D11749: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ChatInputBar`.

land

Wed, Apr 24, 1:21 PM
atul updated the diff for D11748: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`.

land

Wed, Apr 24, 1:20 PM
atul updated the diff for D11747: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `EditThreadAvatar`.

land

Wed, Apr 24, 1:20 PM
atul updated the test plan for D11747: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `EditThreadAvatar`.
Wed, Apr 24, 1:18 PM
atul added a comment to D11747: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `EditThreadAvatar`.

I think you should consider having a test plan that actually verifies that this logic is correct.

Wed, Apr 24, 1:17 PM
atul closed D11746: [lib] Introduce `useThreadHasPermission` hook.
Wed, Apr 24, 1:00 PM
atul committed rCOMM2e193ebaa76c: [lib] Introduce `useThreadHasPermission` hook (authored by atul).
[lib] Introduce `useThreadHasPermission` hook
Wed, Apr 24, 1:00 PM
atul updated the diff for D11746: [lib] Introduce `useThreadHasPermission` hook.

memoize return value of useThreadHasPermission

Wed, Apr 24, 12:57 PM
atul updated the diff for D11746: [lib] Introduce `useThreadHasPermission` hook.

rebase before addressing feedback

Wed, Apr 24, 12:44 PM
atul added inline comments to D11746: [lib] Introduce `useThreadHasPermission` hook.
Wed, Apr 24, 12:42 PM
atul closed D11742: [lib] Pull `filterOutDisabledPermissions(permissionsBitmask)` out of `getCurrentUser`.
Wed, Apr 24, 12:38 PM
atul committed rCOMMec961262c8c1: [lib] Pull `filterOutDisabledPermissions(permissionsBitmask)` out of… (authored by atul).
[lib] Pull `filterOutDisabledPermissions(permissionsBitmask)` out of…
Wed, Apr 24, 12:38 PM
atul updated the diff for D11742: [lib] Pull `filterOutDisabledPermissions(permissionsBitmask)` out of `getCurrentUser`.

land trivial

Wed, Apr 24, 12:24 PM
atul closed D11741: [lib] Simplify `threadMemberHasPermission()`.
Wed, Apr 24, 12:23 PM
atul committed rCOMM24c5c5fc270d: [lib] Simplify `threadMemberHasPermission()` (authored by atul).
[lib] Simplify `threadMemberHasPermission()`
Wed, Apr 24, 12:23 PM
atul attached a referenced file: F1654016: 851623.png.
Wed, Apr 24, 12:22 PM
atul added inline comments to D11742: [lib] Pull `filterOutDisabledPermissions(permissionsBitmask)` out of `getCurrentUser`.
Wed, Apr 24, 12:22 PM
atul updated the diff for D11741: [lib] Simplify `threadMemberHasPermission()`.

land trivial

Wed, Apr 24, 12:14 PM
atul closed D11740: [lib] Rename `getMinimallyEncodedCurrentUser` -> `getCurrentUser`.
Wed, Apr 24, 11:00 AM
atul committed rCOMM748e7c47a7e0: [lib] Rename `getMinimallyEncodedCurrentUser` -> `getCurrentUser` (authored by atul).
[lib] Rename `getMinimallyEncodedCurrentUser` -> `getCurrentUser`
Wed, Apr 24, 11:00 AM
atul updated the diff for D11740: [lib] Rename `getMinimallyEncodedCurrentUser` -> `getCurrentUser`.

land trivial

Wed, Apr 24, 10:59 AM

Tue, Apr 23

atul requested review of D11754: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.
Tue, Apr 23, 3:14 PM
atul requested review of D11753: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings*`.
Tue, Apr 23, 2:05 PM
atul requested review of D11752: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `MembersModal`.
Tue, Apr 23, 1:53 PM
atul requested review of D11751: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `CommunityActionsMenu`.
Tue, Apr 23, 1:52 PM
atul requested review of D11750: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadMenu`.
Tue, Apr 23, 1:51 PM
atul requested review of D11749: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ChatInputBar`.
Tue, Apr 23, 1:43 PM
atul requested review of D11748: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`.
Tue, Apr 23, 1:34 PM
atul requested review of D11747: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `EditThreadAvatar`.
Tue, Apr 23, 1:07 PM
atul requested review of D11746: [lib] Introduce `useThreadHasPermission` hook.
Tue, Apr 23, 12:51 PM
atul requested review of D11742: [lib] Pull `filterOutDisabledPermissions(permissionsBitmask)` out of `getCurrentUser`.
Tue, Apr 23, 11:11 AM
atul requested review of D11741: [lib] Simplify `threadMemberHasPermission()`.
Tue, Apr 23, 11:09 AM
atul requested review of D11740: [lib] Rename `getMinimallyEncodedCurrentUser` -> `getCurrentUser`.
Tue, Apr 23, 10:57 AM

Mon, Apr 22

atul closed D11204: [web][native][keyserver] Flip the switch to enable `specialRole` field.
Mon, Apr 22, 6:34 PM
atul committed rCOMMbbac2afa8f62: [web][native][keyserver] Flip the switch to enable `specialRole` field (authored by atul).
[web][native][keyserver] Flip the switch to enable `specialRole` field
Mon, Apr 22, 6:34 PM
atul updated the diff for D11204: [web][native][keyserver] Flip the switch to enable `specialRole` field.

change web minCodeVersion to NEXT_CODE_VERSION

Mon, Apr 22, 6:25 PM