Paths

Table of Contentst

Differential D3489

[services] Backup - Add comments to the db entities
ClosedPublic
Actions

Authored by • karol on Mar 22 2022, 3:37 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Apr 16 2024, 9:05 AM

	Unknown Object (File)
	Mar 28 2024, 2:08 PM

	Unknown Object (File)
	Mar 28 2024, 2:08 PM

	Unknown Object (File)
	Mar 28 2024, 2:08 PM

	Unknown Object (File)
	Mar 28 2024, 2:07 PM

	Unknown Object (File)
	Mar 28 2024, 1:58 PM

	Unknown Object (File)
	Mar 18 2024, 5:21 PM

	Unknown Object (File)
	Mar 16 2024, 7:57 AM

View All 86 Files

Subscribers

Details

Reviewers

varun
• max
• jim
tomek

Commits

rCOMM489a50d1db4c: [services] Backup - Add comments to the db entities

Summary

Context - https://phabricator.ashoat.com/D2950#93128

Some comments to clarify things around DB entities.

Test Plan

None - these are just comments

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Mar 22 2022, 3:37 AM

Herald added subscribers: • benschac, atul, • adrian and 2 others. · View Herald TranscriptMar 22 2022, 3:37 AM

• karol edited the summary of this revision. (Show Details)Mar 22 2022, 3:39 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: varun, • max, • jim, tomek.

Harbormaster completed remote builds in B7525: Diff 10591.Mar 22 2022, 3:41 AM

• karol requested review of this revision.Mar 22 2022, 3:41 AM

varun requested changes to this revision.Mar 22 2022, 10:55 AM

varun added inline comments.

services/backup/docker-server/contents/server/src/DatabaseEntities/LogItem.h
15 ↗	(On Diff #10591)	it's not clear to me what `value` is from this definition. i suggest not using the term itself in the definition if possible.

This revision now requires changes to proceed.Mar 22 2022, 10:55 AM

ashoat added inline comments.Mar 22 2022, 9:51 PM

services/backup/docker-server/contents/server/src/DatabaseEntities/LogItem.h
15 ↗	(On Diff #10591)	Nit: you're still doing the thing where you skip spaces before parantheses

update

• karol added inline comments.Mar 23 2022, 8:23 AM

services/backup/docker-server/contents/server/src/DatabaseEntities/LogItem.h
15 ↗	(On Diff #10591)	Nit: you're still doing the thing where you skip spaces before parantheses sorry I just copied it and didn't notice it's not clear to me what `value` is from this definition. i suggest not using the term itself in the definition if possible. Ok, I updated the description trying to be more descriptive this time. I'm not sure if using the word "value" can be easily avoided here.

Harbormaster completed remote builds in B7544: Diff 10613.Mar 23 2022, 8:32 AM

varun accepted this revision.Mar 28 2022, 7:41 AM

This revision is now accepted and ready to land.Mar 28 2022, 7:41 AM

tomek accepted this revision.Mar 29 2022, 3:11 AM

Closed by commit rCOMM489a50d1db4c: [services] Backup - Add comments to the db entities (authored by • karol). · Explain WhyMar 29 2022, 4:31 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM489a50d1db4c: [services] Backup - Add comments to the db entities.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

DatabaseEntities/

11 lines

8 lines

Diff 10760

services/backup/docker-server/contents/server/src/DatabaseEntities/BackupItem.h

Loading...

services/backup/docker-server/contents/server/src/DatabaseEntities/LogItem.h

Loading...