Paths

Table of Contentst

Differential D11570

[protos][identity] Add RPC for fetching multiple device lists
ClosedPublic
Actions

Authored by bartek on Apr 8 2024, 2:27 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 16, 8:47 AM

	Unknown Object (File)
	Fri, Apr 26, 6:18 PM

	Unknown Object (File)
	Thu, Apr 25, 10:14 AM

	Unknown Object (File)
	Mon, Apr 22, 1:01 PM

	Unknown Object (File)
	Mon, Apr 22, 11:25 AM

	Unknown Object (File)
	Apr 17 2024, 12:34 AM

	Unknown Object (File)
	Apr 13 2024, 6:23 PM

	Unknown Object (File)
	Apr 13 2024, 4:34 PM

View All 12 Files

Subscribers

Details

Reviewers

ashoat
varun
kamil

Commits

rCOMMa8ad5e68ca0f: [protos][identity] Add RPC for fetching multiple device lists

Summary

Addresses ENG-7591.

Depends on D11551

Test Plan

Added integration test
Registered a few users and tested the RPC manually

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Apr 8 2024, 2:27 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptApr 8 2024, 2:27 AM

bartek edited the summary of this revision. (Show Details)Apr 8 2024, 2:28 AM

bartek added a parent revision: D11551: [protos] Replace challengeResponse with nonce and signature pair.

Harbormaster completed remote builds in B28038: Diff 38884.Apr 8 2024, 2:42 AM

bartek published this revision for review.Apr 8 2024, 2:50 AM

bartek added inline comments.

services/commtest/tests/identity_device_list_tests.rs
245–255 ↗	(On Diff #38884)	I could've simplified that.

ashoat accepted this revision.Apr 8 2024, 5:53 AM

ashoat added inline comments.

shared/protos/identity_auth.proto
211 ↗	(On Diff #38884)	Accidental double `//`
213 ↗	(On Diff #38884)	The payload structure described in `GetDeviceListResponse` does not include signatures, which makes the reference to `SignedDeviceList` here confusing

bartek added inline comments.Apr 8 2024, 11:24 PM

shared/protos/identity_auth.proto
213 ↗	(On Diff #38884)	This payload structure is finally going to have signatures when I add them later this month, but I probably should replace `SignedDeviceList payloads` with just `device list payloads` - the `SignedDeviceList` is a Rust/Flow struct, not a proto message, so it shouldn't be mentioned.

kamil accepted this revision.Apr 10 2024, 3:46 AM

varun accepted this revision.Apr 10 2024, 10:59 AM

This revision is now accepted and ready to land.Apr 10 2024, 10:59 AM

Rebase before landing, fix comment in proto

Harbormaster completed remote builds in B28185: Diff 39074.Apr 12 2024, 3:46 AM

Closed by commit rCOMMa8ad5e68ca0f: [protos][identity] Add RPC for fetching multiple device lists (authored by bartek). · Explain WhyApr 15 2024, 1:44 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMa8ad5e68ca0f: [protos][identity] Add RPC for fetching multiple device lists.

kamil mentioned this in D11832: [native] implement `GetDeviceListsForUsers` RPC in `native_rust_library`.Tue, Apr 30, 2:53 AM

Revision Contents
Changeset List

Path

Size

services/

commtest/

tests/

identity_device_list_tests.rs

64 lines

identity/

src/

grpc_services/

authenticated.rs

69 lines

shared/

protos/

identity_auth.proto

16 lines

web/

protobufs/

identity-auth-client.cjs

identity-auth-client.cjs.flow

12 lines

identity-auth-structs.cjs

identity-auth-structs.cjs.flow

34 lines

Diff 39107

services/commtest/tests/identity_device_list_tests.rs

Loading...

services/identity/src/grpc_services/authenticated.rs

Loading...

shared/protos/identity_auth.proto

Loading...

web/protobufs/identity-auth-client.cjs

Loading...

web/protobufs/identity-auth-client.cjs.flow

Loading...

web/protobufs/identity-auth-structs.cjs

Loading...

web/protobufs/identity-auth-structs.cjs.flow

Loading...