Improve test plan
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Tue, May 7
Mon, May 6
Sun, May 5
Thu, May 2
iOS build failure looks unrelated
i think @bartek should take a look when he's back
I was imagining that all the prefixes (e.g. DB Error) would be defined in a module in constants.rs and then used like this:
Wed, May 1
shouldn't we check that the ServerError is olm_session_creation_failure when determining whether to retry? We'll be spending one of the keyserver's OTKs unnecessarily if the error is not OLM-related
what happens if identity account deletion fails after the failed keyserver auth? should we notify the user that their account was registered successfully?
Tue, Apr 30
In D11705#339313, @tomek wrote:logging in on web, and then flipping usingCommServicesAccessToken to true
I don't think there's a chance that a flag will flip while the app is working. Have you tried refreshing the app after the flag is set? (this would emulate receiving a new web code version)
Mon, Apr 29
check if !commServicesAccessToken in useLogOut hook
The keyserver errors:
[NODEM] ServerError: socket_deauthorized [NODEM] at WebSocket.<anonymous> (file:///Users/varun/Code/comm/keyserver/dist/socket/socket.js:128:17) [NODEM] at process.processTicksAndRejections (node:internal/process/task_queues:95:5) { [NODEM] payload: undefined, [NODEM] platformDetails: undefined, [NODEM] sanitizedInput: undefined [NODEM] } [NODEM] /Users/varun/Code/comm/node_modules/@commapp/olm/olm.js:19 [NODEM] if(ia)m=l?require("path").dirname(m)+"/":__dirname+"/",na=()=>{ma||(fs=require("fs"),ma=require("path"))},ja=function(b,c){na();b=ma.normalize(b);return fs.readFileSync(b,c?void 0:"utf8")},la=b=>{b=ja(b,!0);b.buffer||(b=new Uint8Array(b));return b},ka=(b,c,d)=>{na();b=ma.normalize(b);fs.readFile(b,function(e,f){e?d(e):c(f.buffer)})},1<process.argv.length&&process.argv[1].replace(/\\/g,"/"),process.argv.slice(2),process.on("uncaughtException",function(b){throw b;}),process.on("unhandledRejection", [NODEM] ^ [NODEM] [NODEM] Invariant Violation: should be set [NODEM] at invariant (/Users/varun/Code/comm/node_modules/invariant/invariant.js:40:15) [NODEM] at WebSocket.<anonymous> (file:///Users/varun/Code/comm/keyserver/dist/socket/socket.js:177:9) [NODEM] at process.processTicksAndRejections (node:internal/process/task_queues:95:5) { [NODEM] framesToPop: 1 [NODEM] } [NODEM] [NODEM] Node.js v20.10.0
Separately, I'd like to see the test plan extended. @varun, could you try to simulate what would happen to a web client the first time it sees usingCommServicesAccessToken get flipped?
In D11705#339275, @varun wrote:That said I wouldn't be opposed to adding an || !commServicesAccessToken condition here.
Did you link the right line?
That said I wouldn't be opposed to adding an || !commServicesAccessToken condition here.