Page MenuHomePhabricator
Feed Advanced Search

Tue, May 7

varun added inline comments to D11910: [native] add reserved registration methods to IdentityServiceContextProvider.
Tue, May 7, 2:40 PM

Mon, May 6

varun requested review of D11910: [native] add reserved registration methods to IdentityServiceContextProvider.
Mon, May 6, 7:52 AM
varun planned changes to D11912: [lib] add reserved username workflow to identity login actions.

Improve test plan

Mon, May 6, 7:50 AM
varun published D11912: [lib] add reserved username workflow to identity login actions for review.
Mon, May 6, 7:49 AM
varun planned changes to D11911: [lib] hooks for reserved registration.
Mon, May 6, 7:48 AM
varun published D11911: [lib] hooks for reserved registration for review.
Mon, May 6, 7:48 AM
varun requested review of D11909: [native] add registerReservedWalletUser and registerReservedPasswordUser to CommRustModule.
Mon, May 6, 7:43 AM
varun requested review of D11908: [native_rust_library] reserved registration client methods for wallet and password users.
Mon, May 6, 7:38 AM
varun requested review of D11906: [native] handler that just logs out if missing CSAT and no password.
Mon, May 6, 7:36 AM

Sun, May 5

varun accepted D11891: [native] Don't send reserved ETH addresses to registration flow.
Sun, May 5, 10:38 PM
varun closed D11860: [web] differentiate between password and wallet users in MissingCSATModal.
Sun, May 5, 5:29 PM
varun committed rCOMM65d6768c3ff8: [web] differentiate between password and wallet users in MissingCSATModal (authored by varun).
[web] differentiate between password and wallet users in MissingCSATModal
Sun, May 5, 5:29 PM
varun closed D11844: [web] display modal explaining why user was logged out.
Sun, May 5, 5:29 PM
varun closed D11705: [web] log out if CSAT is missing.
Sun, May 5, 5:29 PM
varun committed rCOMM4dcf358d2c31: [web] display modal explaining why user was logged out (authored by varun).
[web] display modal explaining why user was logged out
Sun, May 5, 5:29 PM
varun committed rCOMM1c3ad32e1772: [web] log out if CSAT is missing (authored by varun).
[web] log out if CSAT is missing
Sun, May 5, 5:29 PM

Thu, May 2

varun requested review of D11861: [native_rust_library] refactor helper structs to avoid duplication.
Thu, May 2, 10:34 PM
varun added inline comments to D11860: [web] differentiate between password and wallet users in MissingCSATModal.
Thu, May 2, 10:29 PM
varun requested review of D11860: [web] differentiate between password and wallet users in MissingCSATModal.

iOS build failure looks unrelated

Thu, May 2, 10:10 PM
varun accepted D11853: [terraform] metric filters for error logs in identity service.
Thu, May 2, 11:37 AM
varun added inline comments to D11854: [terraform] identity service cloudwatch alarms.
Thu, May 2, 11:35 AM
varun accepted D11854: [terraform] identity service cloudwatch alarms.

i think @bartek should take a look when he's back

Thu, May 2, 11:34 AM
varun requested changes to D11852: [identity] Add prefixes to error logs for filtering.

I was imagining that all the prefixes (e.g. DB Error) would be defined in a module in constants.rs and then used like this:

Thu, May 2, 11:29 AM
varun accepted D11848: [lib][native] Automatically retry keyserverAuth during login/registration.
Thu, May 2, 5:13 AM

Wed, May 1

varun accepted D11845: [lib][native] Reset login state if authoritative keyserver fails.
Wed, May 1, 7:01 PM
varun accepted D11849: [native] Prevent user from leaving RegistrationTerms during registration request.
Wed, May 1, 11:46 AM
varun requested changes to D11848: [lib][native] Automatically retry keyserverAuth during login/registration.

shouldn't we check that the ServerError is olm_session_creation_failure when determining whether to retry? We'll be spending one of the keyserver's OTKs unnecessarily if the error is not OLM-related

Wed, May 1, 10:51 AM
varun accepted D11847: [native] Show "unknown error" alert if keyserver auth fails during registration.
Wed, May 1, 10:21 AM
varun accepted D11846: [lib][native][web] Wait until database deletion before rejecting login/registration attempt.
Wed, May 1, 10:21 AM
varun requested changes to D11845: [lib][native] Reset login state if authoritative keyserver fails.

what happens if identity account deletion fails after the failed keyserver auth? should we notify the user that their account was registered successfully?

Wed, May 1, 10:14 AM

Tue, Apr 30

varun accepted D11851: [identity] remove duplicate debug log for HTTP requests.
Tue, Apr 30, 1:41 PM
varun accepted D11850: [identity] Disable external crate debug messages.
Tue, Apr 30, 1:35 PM
varun requested review of D11844: [web] display modal explaining why user was logged out.
Tue, Apr 30, 9:56 AM
varun added a comment to D11705: [web] log out if CSAT is missing.

logging in on web, and then flipping usingCommServicesAccessToken to true

I don't think there's a chance that a flag will flip while the app is working. Have you tried refreshing the app after the flag is set? (this would emulate receiving a new web code version)

Tue, Apr 30, 9:40 AM

Mon, Apr 29

varun accepted D11830: [identity] add span tracing to token.rs.
Mon, Apr 29, 2:01 PM
varun accepted D11829: [identity] Add span tracing to one_time_keys.rs.
Mon, Apr 29, 2:01 PM
varun accepted D11828: [identity] add span tracing to identity device_list.rs functions.
Mon, Apr 29, 2:01 PM
varun updated the diff for D11705: [web] log out if CSAT is missing.

check if !commServicesAccessToken in useLogOut hook

Mon, Apr 29, 2:00 PM
varun added a comment to D11705: [web] log out if CSAT is missing.

The keyserver errors:

[NODEM] ServerError: socket_deauthorized
[NODEM]     at WebSocket.<anonymous> (file:///Users/varun/Code/comm/keyserver/dist/socket/socket.js:128:17)
[NODEM]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
[NODEM]   payload: undefined,
[NODEM]   platformDetails: undefined,
[NODEM]   sanitizedInput: undefined
[NODEM] }
[NODEM] /Users/varun/Code/comm/node_modules/@commapp/olm/olm.js:19
[NODEM] if(ia)m=l?require("path").dirname(m)+"/":__dirname+"/",na=()=>{ma||(fs=require("fs"),ma=require("path"))},ja=function(b,c){na();b=ma.normalize(b);return fs.readFileSync(b,c?void 0:"utf8")},la=b=>{b=ja(b,!0);b.buffer||(b=new Uint8Array(b));return b},ka=(b,c,d)=>{na();b=ma.normalize(b);fs.readFile(b,function(e,f){e?d(e):c(f.buffer)})},1<process.argv.length&&process.argv[1].replace(/\\/g,"/"),process.argv.slice(2),process.on("uncaughtException",function(b){throw b;}),process.on("unhandledRejection",
[NODEM]                                                                                                                                                                                                                                                                                                                                                                                                                                                                           ^
[NODEM] 
[NODEM] Invariant Violation: should be set
[NODEM]     at invariant (/Users/varun/Code/comm/node_modules/invariant/invariant.js:40:15)
[NODEM]     at WebSocket.<anonymous> (file:///Users/varun/Code/comm/keyserver/dist/socket/socket.js:177:9)
[NODEM]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
[NODEM]   framesToPop: 1
[NODEM] }
[NODEM] 
[NODEM] Node.js v20.10.0
Mon, Apr 29, 1:58 PM
varun added a comment to D11705: [web] log out if CSAT is missing.

Separately, I'd like to see the test plan extended. @varun, could you try to simulate what would happen to a web client the first time it sees usingCommServicesAccessToken get flipped?

Mon, Apr 29, 1:55 PM
varun updated the test plan for D11705: [web] log out if CSAT is missing.
Mon, Apr 29, 1:45 PM
varun added a comment to D11705: [web] log out if CSAT is missing.

That said I wouldn't be opposed to adding an || !commServicesAccessToken condition here.

Did you link the right line?

Mon, Apr 29, 12:46 PM
varun updated the test plan for D11705: [web] log out if CSAT is missing.
Mon, Apr 29, 12:36 PM
varun added a comment to D11705: [web] log out if CSAT is missing.

That said I wouldn't be opposed to adding an || !commServicesAccessToken condition here.

Mon, Apr 29, 12:31 PM
varun accepted D11827: [identity] add span tracing to identity database.rs file.
Mon, Apr 29, 10:45 AM
varun accepted D11831: [identity] add span tracing to identity farcaster.rs.
Mon, Apr 29, 10:44 AM
varun accepted D11826: [identity] add span tracing to identity websocket server.
Mon, Apr 29, 10:43 AM
varun accepted D11825: [identity] Add span tracing to grpc handlers.
Mon, Apr 29, 10:42 AM
varun accepted D11824: [terraform] add comm_services_use_json_logs env variable for json tracing.
Mon, Apr 29, 10:42 AM

Fri, Apr 26

varun planned changes to D11811: [web][native] mark keys as published before uploading to identity service.
Fri, Apr 26, 1:33 PM
varun updated the test plan for D11810: [keyserver] mark prekeys and OTKs as published right before calling identity service.
Fri, Apr 26, 12:59 PM
varun updated the test plan for D11810: [keyserver] mark prekeys and OTKs as published right before calling identity service.
Fri, Apr 26, 12:52 PM
varun requested review of D11811: [web][native] mark keys as published before uploading to identity service.
Fri, Apr 26, 12:40 PM
varun requested review of D11810: [keyserver] mark prekeys and OTKs as published right before calling identity service.
Fri, Apr 26, 12:35 PM
varun closed D11796: [identity] delete all token data on user account deletion.
Fri, Apr 26, 11:31 AM
varun committed rCOMMb08ab7a0087b: [identity] delete all token data on user account deletion (authored by varun).
[identity] delete all token data on user account deletion
Fri, Apr 26, 11:31 AM
varun closed D11795: [identity] move access token table db methods to separate module.
Fri, Apr 26, 11:31 AM
varun committed rCOMM0ef563d1f949: [identity] move access token table db methods to separate module (authored by varun).
[identity] move access token table db methods to separate module
Fri, Apr 26, 11:31 AM

Thu, Apr 25

varun accepted D11711: [identity] Add verification for replacing a device.
Thu, Apr 25, 10:09 PM
varun requested review of D11796: [identity] delete all token data on user account deletion.
Thu, Apr 25, 5:00 PM
varun requested review of D11795: [identity] move access token table db methods to separate module.
Thu, Apr 25, 4:58 PM
varun closed D11783: [terraform] enable debug logs by default on staging.
Thu, Apr 25, 12:00 PM
varun committed rCOMMbceadd1a6c21: [terraform] enable debug logs by default on staging (authored by varun).
[terraform] enable debug logs by default on staging
Thu, Apr 25, 12:00 PM
varun requested review of D11783: [terraform] enable debug logs by default on staging.
Thu, Apr 25, 11:26 AM

Wed, Apr 24

varun closed D11756: [identity] delete all data for user from otks table on account deletion.
Wed, Apr 24, 6:52 AM
varun committed rCOMMf04aa1f8195f: [identity] delete all data for user from otks table on account deletion (authored by varun).
[identity] delete all data for user from otks table on account deletion
Wed, Apr 24, 6:52 AM
varun closed D11755: [identity] delete otk data on logout.
Wed, Apr 24, 6:52 AM
varun committed rCOMMbac2d9c740ca: [identity] delete otk data on logout (authored by varun).
[identity] delete otk data on logout
Wed, Apr 24, 6:52 AM

Tue, Apr 23

varun requested review of D11756: [identity] delete all data for user from otks table on account deletion.
Tue, Apr 23, 8:54 PM
varun requested review of D11755: [identity] delete otk data on logout.
Tue, Apr 23, 8:53 PM
varun accepted D11687: [identity] Allow UpdateDeviceList RPC to remove devices.
Tue, Apr 23, 5:49 PM

Mon, Apr 22

varun accepted D11686: [identity] Extract device list verification to separate func.
Mon, Apr 22, 2:41 PM
varun accepted D11685: [identity] Add device list timestamp verification.
Mon, Apr 22, 2:35 PM
varun accepted D11710: [terraform] Update staging identity.
Mon, Apr 22, 5:23 AM
varun accepted D11709: [identity] Temporarily revert wallet user check.
Mon, Apr 22, 5:22 AM

Fri, Apr 19

varun closed D11706: [terraform] revert identity image.
Fri, Apr 19, 2:09 PM
varun committed rCOMMc98092642f83: [terraform] revert identity image (authored by varun).
[terraform] revert identity image
Fri, Apr 19, 2:09 PM
varun closed D11704: bump identity version and introduce script for identity releases.
Fri, Apr 19, 2:09 PM
varun committed rCOMM8d3335ab7c24: bump identity version and introduce script for identity releases (authored by varun).
bump identity version and introduce script for identity releases
Fri, Apr 19, 2:09 PM
varun published D11706: [terraform] revert identity image for review.
Fri, Apr 19, 1:13 PM
varun requested review of D11705: [web] log out if CSAT is missing.
Fri, Apr 19, 1:09 PM
varun requested review of D11704: bump identity version and introduce script for identity releases.
Fri, Apr 19, 12:22 PM
varun closed D11590: add deletePasswordUser to IdentityServiceClient.
Fri, Apr 19, 8:43 AM
varun committed rCOMM9ce8370c23e8: add deletePasswordUser to IdentityServiceClient (authored by varun).
add deletePasswordUser to IdentityServiceClient
Fri, Apr 19, 8:43 AM
varun closed D11589: [commRustModule] expose deletePasswordUser to JS.
Fri, Apr 19, 8:43 AM
varun closed D11588: [native_rust_library] implement delete_password_user method and move delete methods to a separate file.
Fri, Apr 19, 8:43 AM
varun committed rCOMM6ce80ef9594e: [commRustModule] expose deletePasswordUser to JS (authored by varun).
[commRustModule] expose deletePasswordUser to JS
Fri, Apr 19, 8:43 AM
varun committed rCOMM6357843146a4: [native_rust_library] implement delete_password_user method and move delete… (authored by varun).
[native_rust_library] implement delete_password_user method and move delete…
Fri, Apr 19, 8:43 AM
varun closed D11587: replace single deleteUser RPC with deleteWalletUser, deletePasswordUserStart, and deletePasswordUserFinish.
Fri, Apr 19, 8:43 AM
varun committed rCOMM65a6df827828: replace single deleteUser RPC with deleteWalletUser, deletePasswordUserStart… (authored by varun).
replace single deleteUser RPC with deleteWalletUser, deletePasswordUserStart…
Fri, Apr 19, 8:43 AM
varun added inline comments to D11587: replace single deleteUser RPC with deleteWalletUser, deletePasswordUserStart, and deletePasswordUserFinish.
Fri, Apr 19, 8:37 AM
varun closed D11695: [identity] remove OTKs in chronological order to make sure there are never more than 100 keys per olm account.
Fri, Apr 19, 8:28 AM
varun committed rCOMM6ed6865e5347: [identity] remove OTKs in chronological order to make sure there are never more… (authored by varun).
[identity] remove OTKs in chronological order to make sure there are never more…
Fri, Apr 19, 8:28 AM
varun added inline comments to D11695: [identity] remove OTKs in chronological order to make sure there are never more than 100 keys per olm account.
Fri, Apr 19, 8:27 AM

Apr 18 2024

varun requested review of D11695: [identity] remove OTKs in chronological order to make sure there are never more than 100 keys per olm account.
Apr 18 2024, 5:07 PM
varun accepted D11689: [lib/web] fix error handling indirection.
Apr 18 2024, 12:24 PM
varun closed D11678: [identity] make sure otk exists when we delete it.
Apr 18 2024, 11:36 AM
varun closed D11677: [identity] make sure we don't call refresh keys task twice when fetching content and notif keys.
Apr 18 2024, 11:36 AM
varun committed rCOMMc4f179752442: [identity] make sure otk exists when we delete it (authored by varun).
[identity] make sure otk exists when we delete it
Apr 18 2024, 11:36 AM
varun closed D11679: [identity] rename otk db method.
Apr 18 2024, 11:36 AM